Mark Herwege

Results 119 comments of Mark Herwege

> 3\. The 'Unit' field can be a **drop down** offering all the possible (currently defined) units supported by Number:Dimensionless I don't think this can easily be generalized. Think about...

> I don't know if it makes any difference, but it seems somehow like a smaller change. It doesn't make a difference (and is actually a bigger change, as item-type...

> I agree. 'item-type" is the most obvious and logical holder for this attribute. OK, will look into modifying it to be an attribute to item-type.

> @mherwege do you need to modify Rest API to include the new field JSON? But to answer my own question, I suppose GSON does that automatically.. GSON does, but...

> 1. When editing the 'Unit' field, the Dimension and State Description pattern should ideally _synchronize_ with it. I replaced the default pattern with `%.0f %unit%` (in the UI PR)....

> where it should default either "l" or "gal" depending on configured measurement system? I considered it and created the code for it, but I must say I didn't explicitely...

> That is why I was thinking of a drop down plus 'custom' input. Both one and % could be in the standard dropdown (with unit-hint preselected or % if...

> @mherwege given that the UI change has now been merged, I think this one must be merged too. Or?? Would be nice, but the UI PR provides extra functionality...

> @mherwege - this PR fully resolves #3854, so if you change the first word in the PR description from "Solves" to "Resolves", the issue will be automatically closed when/if...

> 2. The price of electricity is a topic of its own > As @jlaur has well explained, the price of electricity consists of many different components. If we think...