Mark Herwege

Results 119 comments of Mark Herwege

> @mherwege thanks for the info. I am not very experienced on OH core programming, so perhaps you can give me some coaching? Some questions below.. > > 1. In...

> How are the current metadata fields (eg. name of the addon and the minimal bundle info you mention) extracted from the addon repository then? > It should be done...

Indeed, it will nor work like that. And the internal UPnP and MDNS discovery services also call thingDiscoverd for each discovered thing. We are not interested in things here. I...

I think the backend should be done by creating a rest api for /rest/addons/suggestions in https://github.com/openhab/openhab-core/blob/af4fce1e4f7faf9e5d89ded3ca31a20aac57ecf7/bundles/org.openhab.core.io.rest.core/src/main/java/org/openhab/core/io/rest/core/internal/addons/AddonResource.java. All the rest is the responsability of javascript in MainUI. I don’t think you...

The POST requirement in the servlet could probably be covered by having all required metadata represented in AddonInfo. What will remain is how to get from the addon xml to...

That needs looking into again, but rather after https://github.com/openhab/openhab-webui/pull/2485. The new PR’s don’t do anything specific for items on trigger channels. As that would need a profile and there is...

I think this issue has been solved in the mean time.

Mappings in the UI sitemap validator have been implemented. So this issue is fixed.

Not for the sitemap generator. But it looks like it is used to check if an access token is required: https://github.com/openhab/openhab-webui/blob/8779dcf694049a810cef2247999d55dd38021821/bundles/org.openhab.ui/web/src/js/openhab/auth.js#L91