helium
helium copied to clipboard
Removed strict version dependency to selenium
Update the chromedriver for linux to latest available
I made minor changes to setup.py file to remove the strict version dependency to selenium and I have updated the chromedriver version for linux to the latest one available
Hello Michael,
are you now happy with the pull request? The changes allow the package to work with either Selenium 3 or 4.
I'm afraid the changes do not work for me. I have Selenium 4.10.0 and am getting:
File "/home/michael/dev/helium/helium/_impl/__init__.py", line 112, in _start_chrome_driver
result = Chrome(options=chrome_options, desired_capabilities=capabilities)
TypeError: __init__() got an unexpected keyword argument 'desired_capabilities'
Please see "Contributing" in https://github.com/mherrmann/selenium-python-helium#Contributing for how to run the tests and reproduce this for yourself. You'll manually need to install selenium==4.10.0
after pip install -Ur requirements/test.txt
because your PR doesn't bump the Selenium version in requirements.
desired_capabilities is deprecated in Selenium 4, can only use browser options