helium icon indicating copy to clipboard operation
helium copied to clipboard

Removed strict version dependency to selenium

Open EmanueleCannizzaro opened this issue 1 year ago • 5 comments

Update the chromedriver for linux to latest available

EmanueleCannizzaro avatar Jun 06 '23 20:06 EmanueleCannizzaro

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 06 '23 20:06 CLAassistant

I made minor changes to setup.py file to remove the strict version dependency to selenium and I have updated the chromedriver version for linux to the latest one available

EmanueleCannizzaro avatar Jun 06 '23 20:06 EmanueleCannizzaro

Hello Michael,

are you now happy with the pull request? The changes allow the package to work with either Selenium 3 or 4.

EmanueleCannizzaro avatar Jun 08 '23 07:06 EmanueleCannizzaro

I'm afraid the changes do not work for me. I have Selenium 4.10.0 and am getting:

  File "/home/michael/dev/helium/helium/_impl/__init__.py", line 112, in _start_chrome_driver
    result = Chrome(options=chrome_options, desired_capabilities=capabilities)
TypeError: __init__() got an unexpected keyword argument 'desired_capabilities'

Please see "Contributing" in https://github.com/mherrmann/selenium-python-helium#Contributing for how to run the tests and reproduce this for yourself. You'll manually need to install selenium==4.10.0 after pip install -Ur requirements/test.txt because your PR doesn't bump the Selenium version in requirements.

mherrmann avatar Jun 12 '23 05:06 mherrmann

desired_capabilities is deprecated in Selenium 4, can only use browser options

nchantarotwong avatar Jul 28 '23 21:07 nchantarotwong