Michel Hermier

Results 438 comments of Michel Hermier

This behavior is normal per definition of fiber error. A non null value in a fiber error indicates that a fiber is in an error state. Therefore a null value...

I see 3 advantages: - Put the definition in one place (Don't repeat yourself) - Remove the bogus definitions (Remove bogus and unused code) - Enforce/documents that these definitions must...

Bug is here: https://github.com/SerenityOS/serenity/blob/589ebbc24eb3acc86f50043f896414fe190a5229/Kernel/FileSystem/VirtualFileSystem.cpp#L321-L325 `parent_custody` is the path to the parent directory of the resolved symlink, while `path` still points to original `/home/anon/symlink` entry. When concatenation happens it produce the...

Problem his deeper than expected, it is possible to create files with any name in the target link path: ``` $ ln -s /tmp/a-non-existing-file /home/anon/symlink $ echo 123 > /home/anon/symlink/foo...

Well, I meant it would help to pretty formatting numbers in code code, not as in print formatting. Sorry for confusion. It is meant to help math people to transfer...

That issue should be value representation dependant. Union tagged values should not be affected.

The problem highly lies in https://github.com/wren-lang/wren/blob/accfa598b3cbc54fdfb33cb568055ed6994a4966/src/vm/wren_value.c#L430 and the notion of equality. One would expect that equality implies same hashing, and this is usually the case, but it is not an...

@Srinivasa314 if previous messages were not clear enough, wren already has 2 types of quality: `==(_)` and `Object.same(_,_)`.

The result of Object.same will depends on WREN_NAN_TAGGING. When enabled bit comparison is performed, otherwise ieee754 equality is performed. Everything else is true.

What way do you think to implement it? Because the easy route is to make methods signatures looks like regular signature, so one can call `super.my_constructor_method(...)`. Though there is a...