flower icon indicating copy to clipboard operation
flower copied to clipboard

Modernize the code for Python 3.8

Open ulgens opened this issue 4 months ago • 4 comments

With the help of pyupgrade

Small cleaning before removing Python 3.8 support (EOL)

ulgens avatar Nov 09 '25 23:11 ulgens

@Nusnus This will help with 3.8 removal and https://github.com/mher/flower/pull/1461

ulgens avatar Nov 10 '25 10:11 ulgens

@Nusnus I can create other PRs to continue with this work. I think it's better to keep them separete and not to risk have huge PRs that hard to navigate.

ulgens avatar Nov 10 '25 11:11 ulgens

@Nusnus I can create other PRs to continue with this work. I think it's better to keep them separete and not to risk have huge PRs that hard to navigate.

Sounds great! Thank you!

Nusnus avatar Nov 10 '25 11:11 Nusnus

@Nusnus Thank you.

Also, about the CI failures,

flower/events.py:18:0: C0103: Variable name "PROMETHEUS_METRICS" doesn't conform to snake_case naming style (invalid-name)

This doesn't come from the changes done in the PR and I didn't care about it much - I'm not even sure why it expects a snake_case naming for a module level variable name. If you have any recommendations, I can handle that in a separate PR.

ulgens avatar Nov 10 '25 11:11 ulgens