flower icon indicating copy to clipboard operation
flower copied to clipboard

Enhancement: Add feature to manually retry failed task

Open yashpapa6969 opened this issue 1 year ago • 11 comments

Change Log

  • API Update: Introduced the TaskReapply endpoint to reapply tasks with original arguments.
  • Error Handling: Ensures JSON-serializable arguments and robust error logging.
  • Backend Utilities: Added helper functions (parse_args, parse_kwargs, make_json_serializable) for argument parsing and serialization.

yashpapa6969 avatar Dec 26 '24 07:12 yashpapa6969

@mher anything I can do to help get this merged?

iloveitaly avatar Jan 21 '25 22:01 iloveitaly

@sc68cal how can i get this merged?

yashpapa6969 avatar Feb 02 '25 17:02 yashpapa6969

@sc68cal how can i get this merged?

I am not the maintainer, the maintainer needs to approve and merge

sc68cal avatar Feb 02 '25 19:02 sc68cal

Thanks for the feature, @mher could we get this merged?

Ragnarow avatar Feb 05 '25 17:02 Ragnarow

Hi! Thanks for adding this awesome feature @yashpapa6969 ! I tested it locally and noticed a small issue: I think we need to add a route for the new controller in flower/urls.py:

    (r"/api/task/reapply/(.+)", tasks.TaskReapply),

Otherwise the Retry button will fail with 404

matias-martini avatar Feb 14 '25 17:02 matias-martini

@matias-martini thank you updated

yashpapa6969 avatar Feb 14 '25 17:02 yashpapa6969

@yashpapa6969 Thanks for the updates! 🙌

Would you mind adding a test for the new API endpoint? It'll help ensure we cover the most common cases.

matias-martini avatar Feb 14 '25 17:02 matias-martini

@yashpapa6969 Thanks for the effort, can we have the tests to merge this?

Ragnarow avatar Mar 18 '25 22:03 Ragnarow

Any update on this?

the-rich-piana avatar Aug 05 '25 16:08 the-rich-piana

Would be great to see this feature merged !

alexandercarruthers avatar Aug 18 '25 11:08 alexandercarruthers

@yashpapa6969, thank you so much for the effort! Could you help us with the tests for it so we can review and merge?

mihai-burduselu-ptt avatar Sep 09 '25 15:09 mihai-burduselu-ptt