flower icon indicating copy to clipboard operation
flower copied to clipboard

Docker tag for 1.0.0 release

Open daveisfera opened this issue 4 years ago • 6 comments

Is your feature request related to a problem? Please describe. 1.0.0 was released but there's not a docker tag for it

Describe the solution you'd like Add tag so 1.0.0 can be used in a docker image

daveisfera avatar Aug 27 '21 18:08 daveisfera

This would be great for us! We used to use the latest tag but unfortunately it broke a while back and we needed to version lock.

cfarrend avatar Sep 01 '21 00:09 cfarrend

For anyone who is watching this, I have built the 1.0.0 release as cfarrend/flower:v1.0.0. I'm basing it off the same code except with one slight Dockerfile modification. If it works out then we'll be using it anyway so it will be maintained to the point of supporting new versions as they come, of course I'd prefer not to. I've also built the latest push to master as cfarrend/flower:master. This should update automatically as pushes are added to this repo hopefully.

See here: https://github.com/mher/flower/compare/v1.0.0...cfarrend:v1.0.0

I'd make a PR here but I'm not sure of the build process to be honest. Possibly done inside Docker Hub itself?

cfarrend avatar Oct 15 '21 07:10 cfarrend

I've created https://github.com/mher/flower/pull/1181 which will switch this project to GitHub Actions for container building. This will bring back master building to latest on merges and also start building release tags again. Docker Hub Automated Builds are disabled by default now which is why this has stopped working.

cardoe avatar Dec 31 '21 17:12 cardoe

@mher Any update on this request? Looks like @cardoe has done the groundwork for this. We too would also like an automated publish of the image without needing to maintain a separate fork ourselves. Thanks!

scottd018 avatar Jul 07 '22 17:07 scottd018

Created the environment secrets and merged the PR

mher avatar Jul 07 '22 21:07 mher

I've followed up on PR #1181 but unfortunately something isn't working yet so we can't close this one out.

cardoe avatar Jul 08 '22 02:07 cardoe