sidekiq-unique-jobs icon indicating copy to clipboard operation
sidekiq-unique-jobs copied to clipboard

Ambiguity about `death_handers`

Open schwern opened this issue 2 years ago • 0 comments

The README says...

Starting in v5.1, Sidekiq can also fire a global callback when a job dies: In version 7, this is handled automatically for you. You don't need to add a death handler, if you configure v7 like in Add the middleware you don't have to worry about the below.

Is "In version 7" referring to version 7 of sidekiq or sidekiq-unique-jobs? In other words, if I'm using sidekiq >= 5.1 and sidekiq-unique-jobs >= 7 I do not need a death_handler?

if that's the case, that it's only for older versions of sidekiq-unique-jobs, I'd suggest removing it from the README; it's just confusing.

schwern avatar Apr 12 '22 02:04 schwern