octokit-commit-multiple-files icon indicating copy to clipboard operation
octokit-commit-multiple-files copied to clipboard

Published 20 hours ago • verified publisher icon mheap

Add TypeScript definitions

Open iddan opened this issue 2 years ago • 5 comments

This is not a complete definition but it was good enough to get me going. Closes #64

iddan avatar Jun 21 '22 16:06 iddan

Hey @iddan, I couldn't get this working for me in VS Code. Could you share any more guidance?

mheap avatar Sep 30 '22 16:09 mheap

Hey @mheap what is the issue you are experiencing?

iddan avatar Oct 02 '22 11:10 iddan

I ran npm link with your fork and the typings were not showing up as expected when I imported the module

mheap avatar Oct 02 '22 12:10 mheap

I see. I don't have the capacity right now to check but the types are extracted from my code repository

iddan avatar Oct 02 '22 12:10 iddan

I had a go at this. Type definitions generated with rm *.d.ts; npx tsc on this branch: https://github.com/mheap/octokit-commit-multiple-files/tree/add-types

I'm struggling how to extend the octokit definitions to include createOrUpdateFiles(). Module augmentation looks promising, but I couldn't get it working

mheap avatar Oct 16 '22 18:10 mheap