Michael Heap

Results 70 comments of Michael Heap

@lucasgonze Added a few comments. Please also update the README with usage instructions

This could be quite noisy for those that don't need the functionality. Would you expect it to be behind a command line flag?

Would they only execute if you have https://github.com/pre-commit/pre-commit installed + configured?

Happy to receive a PR 👍

Currently, there is one event generated per gateway. ``` ❯ kgpn kong NAME READY STATUS RESTARTS AGE echo-56fdff65c-thvdp 1/1 Running 0 110s kong-controller-86f4794d59-2q7lj 1/1 Running 0 2m15s kong-gateway-558599998b-4frzq 1/1 Running...

Sample event payload. `count` is an interesting field: ``` { "metadata": { "name": "echo.1766a79eeca1f142", "namespace": "kong", "uid": "2d87496b-cafc-4fad-afbb-6b84498f3960", "resourceVersion": "93349", "creationTimestamp": "2023-06-08T10:16:51Z" }, "reason": "KongConfigurationApplyFailed", "message": "invalid paths.1: invalid regex:...

@Mierenga Is this ready to review?

@fabianrbz Are we good to review + merge or do you want to add specs first?

Can we keep `custom_values` in a separate list? We can generate templated output from that and it makes the data useful for the UI e.g. a "move to next field"...