Michael Heap
Michael Heap
The _correct_ solution here is for Koko not to validate empty fields in a KIC backed configuration. However, this was too much work for the team during initial discussions. I...
It's closer to "we will never have time to implement this". The correct way to do this is have Gateway mark items as sensitive, then have Koko use that marker...
Let’s close until there’s a concrete need
Hey @alnviana. I wanted to acknowledge your issue, but after spending a little time on it I'd like to hear from other users that are hitting this issue before updating...
Thanks both. I'll try to find some time to reproduce + fix
Alright, I've managed to reproduce (merge queues are _not_ easy if you've not used them before). The issue is that the `merge_queue` event does not contain any context from the...
It should work if you keep the label check on `pull_request` and split the `merge_queue` workflow in to a separate file. This would allow you to use the action with...
@twyatt I've given it a go. Can you test `mheap/github-action-required-labels@merge-queue-support`?
@ericcornelissen I think this is a good addition. For it to be accepted, it would need to be refactored in to `replaceActions` (https://github.com/mheap/pin-github-action/blob/main/replaceActions.js) and tests added
I’d be ok replacing the implementation so long as all of the tests still pass.On 17 Sep 2024, at 18:20, Eric Cornelissen ***@***.***> wrote: @mheap, thanks! Before I do that,...