Michael Dawson

Results 779 comments of Michael Dawson

Still on my radar just pretty busy these days.

I know its been a long time. Hope to get to this over the holidays

I see there MIT is what is in the LICENSE file but we also have the unicode-licence.txt. From https://github.com/nodejs/full-icu-npm#license its not clear if some of the files in the repo...

@srl295 If all of the files were covered by the unicode licence when it came in then I think they should likely just stay that way. In that case I...

Fyi - some info/discussion on this topic is provided in the Node.js Reference architecture: https://github.com/nodeshift/nodejs-reference-architecture/blob/main/docs/development/building-good-containers.md#avoiding-using-npm-to-start-application. It would be good to have a way to run without having to use npm.

This PR seems to make the change for Node.js versions 10 and 12 which are no longer supported. While I can see the change with a working fallback makes sense...

@aksgupta14 are you still willing/interested in getting this feature added? I know this is quite old but looking to see how we move it forward.

@phracek that sounds to me like the equivalent of removing the pino tests. They were added to support pino being part of the "Tested and Verified" list that RH has,...

@zmiklank thanks for the clarification. If I understand correctly we'll still be running the tests as part of the regular RHEL regression tests in which case I'm not as concerned.

When you say the test failed the first time but then succeeded, was that after a successful install, ie no other steps between the first npm test and the second?...