Emacs-wgrep
Emacs-wgrep copied to clipboard
wgrep-helm.el: Add missing Package-Requires for helm
This package requires helm, because it uses helm-grep-split-line from helm-grep.el. See wgrep-helm.el:L47.
helm-grep.el first appeared in Helm 1.4.0, so I've set that as the required version.
Edit was due to an error in my commit message. Fixed!
Your patch does not cause problem right away although, I don't want cyclic reference for helm to avoid loading problem. helm weakly require wgrep-helm. https://github.com/emacs-helm/helm/blob/master/helm-grep.el#L26
helm is a Master, wgrep-helm is a Slave (means optional package for helm user).
This (declare-function helm-grep-split-line "helm-grep")
form is added to suppress elisp byte-compiler warnings.
Thank you for the tip. Hm, yes, this sounds tricky... Please keep this PR open while I consult the rest of the Debian Emacsen Team, because I don't use Helm, and I'm not yet sure what the correct resolution is.
'hoping to provide a follow-up soon, Nicholas