Marc Hartmayer
Marc Hartmayer
@arighi Can you please help with the `TODO`s I've placed in the comments in the code? If we resolve them, I think it's good enough to review and merge then....
> Good idea to pick one. Because there are no stable versions, it should be easy to include a bit of code refactoring. > > Personally, I'm not a Python...
I've created a first RFC PR - feedback is highly appreciated. https://github.com/arighi/virtme-ng/pull/257 What's currently is missing, is the coding style documentation somewhere... Edit: Regarding the CI, you might want to...
> > I agree about adding a comment in the README, maybe under the "Contributing" section? > > Good idea! > > [@mhartmay](https://github.com/mhartmay) just to avoid a deadlock, do you...
@arighi @matttbe Do we want to encourage the developers to use typing hints? If yes, we should probably use `mypy`, `pyright` or `pyre`.
We could add something like: `vng --vfio $ADDR[,ids=...,type=pci,...]` Do we want to use something like `driverctl` [1] for unbinding/binding? [1] https://gitlab.com/driverctl/driverctl
**Note:** I did not test whether this actually fixes the problem since I did not reproduce the problem, but it's very likely as I had similar issues in the past.
Question: Should we raise an error if not all data could be read? Update: What speaks against raising an error is that it would be different to the "original code"...
@moreati I've added timeout handling, but I'm not sure which kind of exception should be raised in case of a timeout (currently, I've `Exception('TODO')`. And I would rather use a...
> @moreati I've added timeout handling, but I'm not sure which kind of exception should be raised in case of a timeout (currently, I've `Exception('TODO')`. And I would rather use...