ember-drag-drop icon indicating copy to clipboard operation
ember-drag-drop copied to clipboard

DragOvering the DraggableObject from one SortableObjects to another not working properly.

Open kesavan-ss opened this issue 2 years ago • 2 comments

Hello, When dragging the object and dragOvering to another list. It was added to the new list even without dropping the item. And not able to shift that item without dropping the currentDragItem. Then I need to drop the current item, drag and dragover the object again to shift the object.

The reason is, const hasSameSortingScope = this. get('currentDragItem.sortingScope ') === emberObject.get('sortingScope'); this.get return undefined in this chain path.

sol: const hasSameSortingScope = this. get('currentDragItem').sortingScope === emberObject.get('sortingScope'); or const hasSameSortingScope = this.currentDragItem.sortingScope === emberObject.sortingScope;

Hopefully, it will not change other behaviors.

Can I create a pull request for this fix?

Thank You:)

kesavan-ss avatar Feb 24 '23 07:02 kesavan-ss

Hi !

I cannot create pull requests because of rights. But I found the solution. In addon/services/drag-coordinator.js, line 79 you can replace : const hasSameSortingScope = this.get('currentDragItem.sortingScope') === emberObject.get('sortingScope');

by : const hasSameSortingScope = this.get('currentDragItem').get('sortingScope') === emberObject.get('sortingScope');

And it will works :)

wambaloo avatar Apr 24 '23 16:04 wambaloo

You have to create the PR in your forked copy in order to submit it.

dgavey avatar Apr 24 '23 16:04 dgavey