ember-drag-drop icon indicating copy to clipboard operation
ember-drag-drop copied to clipboard

data down, actions up

Open jelhan opened this issue 7 years ago • 6 comments

ember-drag-drop does not follow data down, actions up (DDAU) pattern yet. It was discussed and future support announced in some issues (#115, #57, #39). How is the status about that one and is there anything blocking that change?

jelhan avatar Jan 22 '18 15:01 jelhan

Well, it's a pretty major change that would break every existing use currently, so not so simple to just change it.

My loose plan was to do a major refactor at some point to follow DDAU and other changes, but it would be a major version change and obviously not backward compatible.

dgavey avatar Jan 22 '18 20:01 dgavey

@dgavey - this is already implemented so this issue can be closed.

boris-petrov avatar Aug 31 '18 11:08 boris-petrov

Current master does not implement DDAU - at least not for all components. E.g. {{sortable-objects}} still modifies property passed in as sortableObjectList as it's shown by this test.

#123 was such a big change that I'm not sure if this case was just missed or if it does not address DDAU at all. In the discussion of that PR closure actions and DDAU was mixed up a lot. I've had a look at the changes in tests and that ones was only about closure actions but not about DDAU.

The main point about data down, actions up principle is not to modify any data passed into a component.

jelhan avatar Aug 31 '18 12:08 jelhan

@jelhan - you're right. So this issue remains.

boris-petrov avatar Aug 31 '18 12:08 boris-petrov

Any plans to fix this soon? :)

I am using a component that its source is a computed.sort property and really could use this.

Thanks

carlosgalveias avatar Apr 30 '19 09:04 carlosgalveias

PR's welcome. I'm happy to maintain this project (from a managerial perspective), but I really don't have a lot of extra time to spend on it currently unfortunately.

dgavey avatar Apr 30 '19 16:04 dgavey