ember-cli-pagination icon indicating copy to clipboard operation
ember-cli-pagination copied to clipboard

Add ability to show all records

Open mharris717 opened this issue 10 years ago • 8 comments

mharris717 avatar Nov 12 '14 16:11 mharris717

Perhaps add [10][25][50][∞] option as in per page option on Stackoverflow search: http://stackoverflow.com/search?q=ember-cli

broerse avatar Nov 17 '14 06:11 broerse

Not a bad idea

mharris717 avatar Nov 18 '14 19:11 mharris717

Putting new features on hold for a bit while i move some code around, this is near the top of the list when that's done.

mharris717 avatar Nov 18 '14 19:11 mharris717

Yes please take a look at https://github.com/mharris717/ember-cli-pagination/issues/50 first.

broerse avatar Nov 20 '14 06:11 broerse

Any movement on this feature? My team's current work around involves having our API expect NaN and returning all records but that's hacky (obviously). We're definitely interested in working with you on getting this feature implemented but don't want to jump in if a solution is in the works.

slightlytyler avatar Jan 12 '15 19:01 slightlytyler

[∞] could be defined in you application as http://exmer.com/bloggrcouch/posts?perPage=10000000000000 just as http://exmer.com/bloggrcouch/posts?perPage=10 but that is also a hack. Should [∞] be defined as perPage=0 or perPage= or perPage=-1 or perPage=infinite??

broerse avatar Jan 12 '15 20:01 broerse

Is perPage=all not an acceptable solution? Definitely the most intuitive.

slightlytyler avatar Jan 12 '15 20:01 slightlytyler

perPage=all sounds as good to me as anything. Agreed that perPage=99999 is a reasonable (if ugly) hack in the meantime.

There's no code yet written for this on my end. Other projects have taken priority the last month or two. PRs are always appreciated and accepted with great fanfare :)

mharris717 avatar Jan 13 '15 14:01 mharris717