ember-cli-pagination icon indicating copy to clipboard operation
ember-cli-pagination copied to clipboard

Added foundation html/css to pagination template

Open zion opened this issue 7 years ago • 4 comments

The idea would be to default to bootstrap styling unless specifying the style argument when calling the component in the template:

{{page-numbers content=users style="foundation"}}

This is my first experience working with an Ember addon locally, so definitely open to ideas to enhance this idea.

zion avatar Apr 13 '17 21:04 zion

Interested in adding foundation support. But this should be some global setting or perhaps an ember-cli-pagination-foundation with just the template? I will have to think about it.

broerse avatar Apr 13 '17 22:04 broerse

Yea agreed. Having a setting in config/environment.js would be great!

I'm not sure how to do that but I'll look into it.

On Apr 13, 2017, 5:45 PM -0500, Martin Broerse [email protected], wrote:

Interested in adding foundation support. But this should be some global setting or perhaps an ember-cli-pagination-foundation with just the template? I will have to think about it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub (https://github.com/mharris717/ember-cli-pagination/pull/220#issuecomment-294040695), or mute the thread (https://github.com/notifications/unsubscribe-auth/ADKBD2bIBy7tbp23DJ-4tDSMhdPbU_Viks5rvqVzgaJpZM4M9O2p).

zion avatar Apr 14 '17 00:04 zion

Perhaps we can do something like this: https://github.com/hhff/ember-infinity/commit/3aa3a4d30f0e169e987a253990209faa96efb0aa

broerse avatar Apr 14 '17 04:04 broerse

Yea, that could work. We could also include generator blueprints for each style?

ember g foundation-pagination-template ember g bootstrap-pagination-template

zion avatar Apr 14 '17 15:04 zion