ember-auth-easy icon indicating copy to clipboard operation
ember-auth-easy copied to clipboard

ember-auth v9 support

Open mbixby opened this issue 11 years ago • 8 comments

mbixby avatar Nov 20 '13 19:11 mbixby

@mbixby @mharris717 Have you understood the reasoning behind the choices made in making ember auth v9?

It seems to me like the major change is refactoring the code to allow for pluggable modules, but I can only see one implementation of each module and this design choice seems to be a source of a lot of trouble when I have tried to use ember auth v9.

digitalplaywright avatar Nov 20 '13 21:11 digitalplaywright

The changes in EmberAuth 9.0 are drastic. Looking into them now

mharris717 avatar Nov 21 '13 20:11 mharris717

My current thought is that due to the drastic changes in Ember Auth v9, I wouldn't rush to modify EAE immediately. I would absolutely like to do it soon, but I wouldn't put it at the top of my priority list. But that is only my thought after 10-15 min of investigating. I would love everyone's thoughts, and I'm happy to change my mind.

mharris717 avatar Nov 21 '13 20:11 mharris717

@mharris717 The upgrade guide seems to indicate that there are many more interesting changes than what I thought:

  • https://github.com/heartsentwined/ember-auth/blob/master/CHANGELOG.md#upgrade-guide

Would be awesome to have ember-auth v9 support!

FYI. When I tried to get ember auth v9 to work I got some very opaque errors that disappeared when all default modules was included in my bower.json:

    "ember-auth": "~9.0.7",
    "ember-auth-request-jquery": "~1.0.3",
    "ember-auth-response-json": "~1.0.2",
    "ember-auth-strategy-token": "~1.0.2",
    "ember-auth-session-cookie": "~1.0.1",
    "ember-auth-module-ember-data": "~1.0.2",
    "ember-auth-module-auth-redirectable": "~1.0.3",
    "ember-auth-module-action-redirectable": "~1.0.2",
    "ember-auth-module-rememberable": "~1.0.3"

digitalplaywright avatar Nov 22 '13 03:11 digitalplaywright

I'll look into it

mharris717 avatar Nov 22 '13 03:11 mharris717

Thanks for the note about the modules

mharris717 avatar Nov 22 '13 03:11 mharris717

@mharris717 Thanks!

digitalplaywright avatar Nov 22 '13 03:11 digitalplaywright

@mharris717 Did you have a chance to look at this issue? Would be cool to have this in place.

digitalplaywright avatar Dec 11 '13 21:12 digitalplaywright