jekyll-postcss icon indicating copy to clipboard operation
jekyll-postcss copied to clipboard

Possibility to use imports processed by other plugins like `postcss-scss`

Open pedropalau opened this issue 4 years ago • 5 comments

In the following line the @import directive is always treated as a file with the .css extension, but the plugins support now the ".css", ".scss", ".sass" extensions.

https://github.com/mhanberg/jekyll-postcss/blob/acc941e01ab182552fc91ddce93560245f502b04/lib/jekyll/converters/postcss.rb#L56

Should we have the support for other filetypes or maybe allow the use with other plugins like postcss-scss?

pedropalau avatar May 20 '20 04:05 pedropalau

So I think you are bringing up two different things, one of which I think is directly related to this issue.

  1. You noticed that the plugin will only cache .css imports, not scss/sass imports (this is a bug).
  2. You want to be able to use a a different css preprocessor than scss/sass.

Does that sound correct?

mhanberg avatar May 20 '20 15:05 mhanberg

Hi @mhanberg, the first option should be the indicated for this case.

pedropalau avatar May 26 '20 21:05 pedropalau

@peterpalau is it correct to assume that you are using @import as provided by Sass, and not provided by postcss-import?

mhanberg avatar May 27 '20 05:05 mhanberg

@peterpalau is it correct to assume that you are using @import as provided by Sass, and not provided by postcss-import?

Exactly this

adamzapasnik avatar Jun 07 '20 17:06 adamzapasnik

@peterpalau is it correct to assume that you are using @import as provided by Sass, and not provided by postcss-import?

Yeap, exactly that, like @DiodonHystrix said.

pedropalau avatar Jun 25 '20 17:06 pedropalau