pywin32 icon indicating copy to clipboard operation
pywin32 copied to clipboard

_fixup_sdk_dirs in setup.py will become redundant

Open zooba opened this issue 3 years ago • 3 comments

Just as an FYI, I submitted the patch for distutils/setuptools that will make this hack in your setup.py redundant:

https://github.com/mhammond/pywin32/blob/e1c0237a6897dbc4adbfda6470711fade43228b7/setup.py#L530

The PR is at https://github.com/pypa/distutils/pull/153 (and should go into setuptools after that) for reference.

I haven't tried, but I believe the code in your setup.py will still work, and none of the asserts will trigger. So you may not notice anything at all (unless you happen to see that there are twice as many include/lib directories in the compiler commands). There's no good way to detect that it's running with a fixed setuptools, so I guess just be aware that if the asserts do start triggering, it may be intentional and they can be relaxed a bit.

zooba avatar Jun 17 '22 16:06 zooba

Thanks for the heads-up Steve!

mhammond avatar Jun 19 '22 07:06 mhammond

pywin32's build will now fail unless setuptools is fairly recent, so once that lands, I'll just force a requirement on that new version. I'm sure you can imagine how much I want to kill some of the crazy stuff setup.py does :)

mhammond avatar Jun 19 '22 08:06 mhammond

#1936 includes removal of the _fixup_sdk_dirs() mechanism.

kxrob avatar Aug 21 '22 21:08 kxrob

@mhammond @zooba Should this have been closed by https://github.com/mhammond/pywin32/pull/1936 ?

Avasam avatar Mar 12 '24 04:03 Avasam