Mark Hammond

Move the bso_record and key_bundle into the sync15_traits crate.

4

(Which further reinforces that the name of that crate should be something like `sync15-types`) This is preparatory work for a much larger patch that will get us further down the...

Desktop tabs does a couple of things we should: * [Checks each URL is under the max size for a URL](https://searchfox.org/mozilla-central/rev/9dc5ffe42635b602d4ddfc9a4b8ea0befc94975a/services/sync/modules/engines/tabs.js#208-211) * [Checks that the total payload size is smaller...

The fix for #5020 was speculative, as I could not understand why invalid records in the mirror could have such a large impact - it should only have been hit...

Edge case is: * device a deletes a record. * device b is yet to sync the deletion. * account storage is reset (eg, password reset setting up device c)...

Remove duplicate DeviceType enum from .udl files

5

This is the other half of #4397. I'm not sure how I feel about it - on one hand, killing the dupe from .udl files seems great! OTOH though, adding...

Ensure incoming logins records have their fields "fixed up" before being applied

5

When there's an incoming record from sync, the fields should be "fixed up" before they are applied locally - [currently they are just applied as-is](https://github.com/mozilla/application-services/blob/a5c2a16/components/logins/src/update_plan.rs#L207). The mirror should probably have...

On the back of removing the dupes of DeviceType (#4397), , it turns out there's still significant confusion around `DeviceType` - specifically: * We [now say that `DeviceType::Unknown` exists purely...

Avoid Option<DeviceType> in all structs

1

Fixes #4860 It's unfortunate that anyone who deserializes needs to remember to add the custom default path, but we can't add `#[serde(default=...)]` to the enum itself because that's only supported...

Clean the local maven repo before publishing to it

1

Fixes #4738 - see also https://github.com/mozilla-mobile/android-components/pull/11414

Have clean.py try and clean with xcode, and/or clean other iOS specific stuff

1

clean.py (landed via #4094) doesn't make any attempt to clean anything for iOS, but it should. Ryan points it's possible in theory to clean an xcode project from the command-line...