Mark Hammond

Results 678 comments of Mark Hammond

Hey Sammy, I think if #1855 lands this will become far more tractable for UDL and the other languages!

async traits are on main, so this is now just ctors

I'm slightly confused here. The first comment says: > Consider changing how Vec is translated in Kotlin. However, this solution is only valid for our use case. So we are...

> Was primary tricky due to uncertain how to handle Option? So was #[uniffi(type = bytes?)] syntax not feasible? The details are murky, but "not feasible" was probably more like...

yeah, it would want to be a per-language setting IMO.

There's some interest around external/remote/custom types recently, so it would be great to see this looked at again. I'm struggling to work out what's being asked for exactly here though...

Thanks - I guess `Tester` is implemented in Kotlin? Maybe some module naming confusion? We have roughly the same setup [here](https://github.com/mozilla/uniffi-rs/blob/f3f7cccfc1dc5adb65d85473830a229b87244dd6/fixtures/ext-types/uniffi-one/src/lib.rs#L43) and consumed externally [here](https://github.com/mozilla/uniffi-rs/blob/f3f7cccfc1dc5adb65d85473830a229b87244dd6/fixtures/ext-types/lib/tests/bindings/test_imported_types.kts#L19) - but without foreign implementations....

> a question of if the semantics are correct. Yeah, I'm a bit torn here. I don't like breaking consumers, but OTOH, I don't think we ever promised this would...

> Maybe we could add support for `ByRef` args in callback interfaces: > ... > If we could get this to work, then there's still a question of if the...