qstrader icon indicating copy to clipboard operation
qstrader copied to clipboard

Published 20 hours ago • verified publisher icon mhallsmoore

Oanda bar price handler

Open tomhunter-gh opened this issue 8 years ago • 4 comments

tomhunter-gh avatar Feb 11 '17 10:02 tomhunter-gh

Coverage Status

Coverage increased (+0.8%) to 64.8% when pulling cf4a081ae629fa48d82d05d640a192b54fc4a68a on tomhunter-gh:master into 2714ae4b95b362e31a450cda1f0a711777659fce on mhallsmoore:master.

coveralls avatar Feb 12 '17 13:02 coveralls

Coverage Status

Coverage increased (+0.8%) to 64.8% when pulling cf4a081ae629fa48d82d05d640a192b54fc4a68a on tomhunter-gh:master into 2714ae4b95b362e31a450cda1f0a711777659fce on mhallsmoore:master.

coveralls avatar Feb 12 '17 13:02 coveralls

Hi @mhallsmoore, please let me know if you have any thoughts or comments on the above pull request.

A strategy I'm currently trying to code relies upon bar returns that are calculated based on the difference in opening prices. In other words (in live trading) the calculate_signals method should only produce a signal when it has seen the open_price on a new incomplete candle. I'm thinking this means that the price handler has to effectively supply every candle twice, once as an incomplete candle with no close price, and a second time with a close price. I will work on this next.

tomhunter-gh avatar Feb 12 '17 23:02 tomhunter-gh

Hi Tom,

Thanks for making this pull request I'll be taking a good look through it and I'll provide some feedback.

By the way - do you currently have access to the Slack development chat/channel? If not, you can email me at [email protected] and I'll send you a Slack invite...

Cheers,

Mike.

mhallsmoore avatar Feb 13 '17 13:02 mhallsmoore