Lines icon indicating copy to clipboard operation
Lines copied to clipboard

Geometry shader does not do clipping

Open tksuoran opened this issue 2 years ago • 1 comments

I don't see clipping in the geometry shader implementation. Lines with one endpoint behind the camera and other endpoint in front of the camera need to be clipped, otherwise there will be incorrect rendering. This clipping depends on current depth clip control mode.

tksuoran avatar Mar 20 '22 21:03 tksuoran

Hi Timo - thanks for opening the issue!

It has been a while since I worked on this project, but if memory serves - you're right, there is no clipping for the case you describe. In general, these implementations were meant to be more of a proof-of-concept exploration, rather than production ready line rendering. I currently do not have time to look into this, but I am open to PRs :)

mhalber avatar Mar 20 '22 23:03 mhalber