git-imerge
git-imerge copied to clipboard
mhagger
Refactor project structure
This is an effort that I just started, but I wanted to open up this PR for any suggestions/comments/concerns as the process is underway. My intent is to make the project compatible with setuptools and break the code base into separate modules.
@mhagger : if this is something you'd prefer to lead, I understand.
I think it would be prudent to add more tests. Any thoughts on adding support for a testing framework?
This is awesome! I'd thought about doing this but haven't had time to get to it. So it's :sparkles:really great:sparkles: that you are working on this.
I do have one wish: that when you are done, before you ask me to merge you rebase your commits into a logical sequence, such that each commit is self-contained and, for example, commits like "remove extra newlines" are squashed into the commit that introduced the extra newlines. I can help you with this tidying up if you are not into that sort of thing. (As long as you are working on the PR feel free to commit in whatever order you want and rebase at will.) I will try to keep an eye on whatever you push and give feedback when I think it might help.
A note about version numbers:
It's really important that we start defining version numbers for git-imerge. One reason is because packagers need them (e.g., see #54), and it is in our interests to help packagers. The other is that it will make it easier to support users if we can ask them "what version of git-imerge are you using?"
setuptools requires a version number too, doesn't it?
The bigger picture of managing version numbers needn't necessarily be part of your project, but in case you had plans in this direction, please see #54, where I wrote down some thoughts about how we could manage version numbers in a sane way.
I think it would be prudent to add more tests. Any thoughts on adding support for a testing framework?
Absolutely! Are you trying to make me fall in love with you or something, because I should warn you that I'm already married :wink:
But adding a testing framework should be done as part of a separate PR, right?
Ah. I must have skipped that attribute in the setup.py. Ill add it.
I like the link you had in #54 although my thoughts are that we should start simple and only add something like that if we find we need the extra granularity. I have been looking around at other python projects and here is another idea.
Absolutely! Are you trying to make me fall in love with you or something, because I should warn you that I'm already married :wink:
Haha. Frankly Im afraid to start moving code around until I feel like there are some tests that will protect the status quo a bit.
Hmm. Yes I would agree that separating out tests into a different PR would be sensible. It should probably be done first. I'll see what I can do.