Michael H

Results 80 comments of Michael H

So this change requires go 1.16 and so the build requires a new `nifikop-build` image to build successfully. https://hub.docker.com/r/orangeopensource/nifikop-build/tags Can a `orangeopensource/nifikop-build:1.16` image be published? Once that's done, builds on...

> So this change requires go 1.16 and so the build requires a new `nifikop-build` image to build successfully. > > https://hub.docker.com/r/orangeopensource/nifikop-build/tags > > Can a `orangeopensource/nifikop-build:1.16` image be published?...

I raised #150 to be able to add custom labels to nifi pods, but it hasn't been merged yet. You can already add custom pod annotations if that would suit:...

I've rebased this on the latest master

I've fixed the build on this PR as i mimicked changes seen in fe69e9eddd7e10ed7cc8ab6aa8d9b1c1ea73d133

Helm will add those metadata properties for you when you specify the `--namespace` argument via the helm client. :) This is also shown in the docs: https://orange-opensource.github.io/nifikop/docs/2_setup/1_getting_started#installing-with-helm Do some resources...

> > Do some resources not get created in the specified namespace? > > ``` > # helm template nifikop orange-incubator/nifikop \ > --version 0.7.5 \ > --set image.tag=v0.7.5-release \...

LGTM. Only comment is whether this is easily verified by a unit test. 🙂

Will this repo be archived so it's clear that the new home of nifikop is under https://github.com/konpyutaika?

perhaps `NiFiCluster.spec.extraArgs` could be added to run additional commands to be added here: https://github.com/Orange-OpenSource/nifikop/blob/master/pkg/resources/nifi/pod.go#L452 I think it's a straightforward change.