Mike Griego

Results 8 comments of Mike Griego

Still need to update the tests...

@matthewgoslett All tests here pass except for the PHP nightly. That failure is actually due to changes in the `count()` function and the fact that the older version of Mockery...

Also, @matthewgoslett, I made the default when `visibility` is not explicit to *not* set an ACL (predefined or otherwise) so that the bucket's default ACL would be applied as expected....

@matthewgoslett Not in the base adapters. If you look at the local and FTP adapters, for instance, the visibility is only set if `visibility` is defined in the `write`, etc...

Same is actually true for the S3 adapter.

Per the spec, these changes make sense. In fact, based on my reading of the spec, only a single `301`, `302`, or `307` redirect should be allowed: a scheme change...

I suggest we only allow two styles of redirect (made this same comment in the slack channel): 1. Scheme modifications 2. Redirects to a different domain within the same domain...