Marc Gravell

Results 638 comments of Marc Gravell

> Can you please confirm if there is any chance to fix this? Without a concrete repro? Very little. I haven't seen this outcome, and I can't picture what would...

That particular example is the long-obsolete redis-sharp, only retained for backwards tests. It's "grandfathered", effectively. However, your point is valid. If we don't already have an editorconfig rule for this,...

`RedisChannel` seems to have a new `bool` field, increasing the size; to simplify design and avoid additional storage, since `SSUBSCRIBE` does not support wildcards, I wonder if we should implement...

~~Does this actually work without error? I'm a little surprised because I would have expected `CheckReadOnlyOperations` to fail, because I don't think you've modified `IsPrimaryOnly`?~~ My bad; found them

Sorry, took my eyes off this one; let's get this done! if you're not still eager, I can probably take it over; but! 1: I really don't like these constructors:...

I've taken the liberty of pushing the merge fixes; I've also proposed the single-field refactor here: https://github.com/vandyvilla/StackExchange.Redis/pull/1 - would love to get your input / thoughts here @vandyvilla , although...

working on adding some tests; very much needed (this could be from my changes, note): ![image](https://github.com/StackExchange/StackExchange.Redis/assets/17328/be603f89-a5f4-4bc2-be3c-522dc9d66a33)

found and fixed; that was a genuine bug in RedisDatabase ![image](https://github.com/StackExchange/StackExchange.Redis/assets/17328/b4fc98a9-9f21-4e08-8841-2cf9e7049d44)

right, I think that's everything - @vandyvilla if you want to merge https://github.com/vandyvilla/StackExchange.Redis/pull/1, then I should be able to pull in the combined effort (preserving your credit, etc)

important TODOs before final merge: - [ ] investigate break/reconnect logic - [ ] investigate cluster shard migration logic - [ ] investigate unsubscribe-all logic