Martijn Govers

Results 46 comments of Martijn Govers

The [PowerGridModel/power-grid-model](https://github.com/PowerGridModel/power-grid-model) moved to https://archives.boost.io/ but it also appears to be flaky. Restarting our CI once or twice does fix the issue, but it's not really the optimal solution. We've...

I've been thinking about that as well. Let's discuss offline

> At the moment the `tap_position_optimizer` still writes everything to a `SolverOutput`. The addition of `MathOutput` to include both `SolverOutput` and `OptimizerOutput` seems ignored. @mgovers Could the `automatic tap changer`...

I have the same problem since this morning. Was working fine yesterday.

This will make the PyArrow conversions also easier ( https://github.com/orgs/PowerGridModel/discussions/2 ) Relates to https://github.com/PowerGridModel/power-grid-model-io/issues/190

Implementation proposal step 7.ii: > 7. Make id optional in update dataset: in the main core, we need to have special treatment in is_update_independent to make id as optional attribute...

Continuing [this thread](https://github.com/PowerGridModel/power-grid-model/pull/799#issuecomment-2428374189) and [this thread](https://github.com/PowerGridModel/power-grid-model/pull/799#issuecomment-2428416850) from #799 for potential follow-up improvements to columnar data here because this issue is still alive and kicking. We can convert this to one...

> > Implementation proposal step 7.ii: > > > 7. Make id optional in update dataset: in the main core, we need to have special treatment in is_update_independent to make...

I removed the `good-first-issue` label because all easy-to-fix things were fixed and merged. the remaining issues require more extensive knowledge and/or a discussion about our own opinion on the smells

> @mgovers I have reviewed and approved the PR. I am not sure if this should now be merged before `main_model` is ready. i don't think it matters. with the...