PUT not putting changes when model is get through $object

[windevalley]

restanglar v1.3.1

$scope.data = Restangular.one("collection", "1245").get().$object;
// I got back

{ 
  title: "some title"
}

$scope.data.title = "title 123";
$scope.data.put();

It will not put the changes.

But if get through promise it will work.

Restangular.one("collection", "1245").get().then(function(result) {
  $scope.data = result;
});
$scope.data.title = "title 123";
$scope.data.put(); // will work

[mgonto]

Hey,

Thanks for the report!

Can you provide a plunkr or jsfiddle with an example?

You can use http://angularjstalk.apiary.io/movies API as an example.

[windevalley]

I make a jsfiddle http://jsfiddle.net/jAy4n/

but http://angularjstalk.apiary.io/movies don't accept /GET http://angularjstalk.apiary.io/movies/1 and http://angularjstalk.apiary.io/directors/1 don't accept /PUT http://angularjstalk.apiary.io/directors/1

So the jsfiddle is incomplete.

[merlinran]

I also faced same issue and created an example at http://jsfiddle.net/merlinran/8fvGh/ Same if I change put() to post().

http://jsonplaceholder.typicode.com/ is a great API for test.

[jondthompson]

Can this please get bumped? It's kind of a big bug.

[Quji]

+1

[mindmelting]

+1

[GarPit]

+1

[dslawrence]

+1

[diaakasem]

+1

[TheHandsomeCoder]

+1

[picitujeromanov]

+1

[deckchairlabs]

+1

[garhbod]

+1

[garhbod]

The fault is the following line 890

 _.extend(filledValue, data);

When the extend(or even merge) function is used to push the restangular response data into the filledValue it breaks the bindData for the put function.

maybe a callback function could be implemented to simply replace the empty object {} with the data rather than push it with extend

[garhbod]

To try and explain what I was trying to say here is two examples.

First if I manually do what $object does which results and the put containing the original data and not work.

    $scope.itemData = {};
    pagesRest.one(id).get().then(function(data) {
      angular.extend($scope.itemData, data);
    });

The Second is the same result on the front end but makes the save work.

    $scope.itemData = {};
    pagesRest.one(id).get().then(function(data) {
      $scope.itemData = data;
    });

[garhbod]

Someone with a bit more knowledge might come up with a better solution but my pull request #1091 fixed the problem for me.

Based off @gonzofish .restanularizeElement solution from issue #713

[peter-bertuglia]

Based on @garhbod's pull request, but without modifying restangular itself, I came up with this quick fix:

    .run(['Restangular', function (Restangular) {
      Restangular.addResponseInterceptor(function (data, operation, what, url, response, deferred) {
        var el = _.extend(deferred.promise.$object, data);
        return Restangular.restangularizeElement(data[Restangular.configuration.restangularFields.parentResource], el, what);
      });
    }])

[gonzofish]

@peter-bertuglia does that account for data that might be from the server but hasn't been Restangularized?

[peter-bertuglia]

@gonzofish I'm not sure what you mean by "might be from the server," this code is Restangularizing the object that is definitely coming from the server, it's intercepting the response

[gonzofish]

Sorry, my fault. I read the code the wrong way...thought it was a request interceptor...stupid me.

[olibri-us]

I am still experiencing the same issue, it looks like it's been there for a while now... The "copy" method works but it adds quite some load on big objects. Could there be a patch please ?

Truly yours, a coder in pain ;)

[victorsosa]

yet another +1

[saniaky]

+1

[ThomasCedrini]

@peter-bertuglia Great !! Here is an upgrade handling collections as well as element.

Restangular.addResponseInterceptor(function (data, operation, what, url, response, deferred) {
    var el = _.extend(deferred.promise.$object, data);

    if(angular.isArray(el))
	return Restangular.restangularizeCollection(data[Restangular.configuration.restangularFields.parentResource], el, what);

    return Restangular.restangularizeElement(data[Restangular.configuration.restangularFields.parentResource], el, what);
});

EDIT

There were too much codes.. this is well enough :

Restangular.addResponseInterceptor(function (data, operation, what, url, response, deferred) {
    return _.extend(deferred.promise.$object, data);
});

With the previous version, if you did a Restangular.extendModel, you received twice each resource instead of once. And when working with events, those were triggered twice..

Bye !