phpstan-drupal icon indicating copy to clipboard operation
phpstan-drupal copied to clipboard

Published 20 hours ago • verified publisher icon mglaman

Adding the fix for the webflow

Open DEVDESAGAR1 opened this issue 9 months ago • 8 comments

Adding the fix for the webflow

fixes #756

DEVDESAGAR1 avatar May 09 '24 10:05 DEVDESAGAR1

Well, that sucks. \DrupalFinder\DrupalFinderComposerRuntime::getVendorDir is picking up InstalledVersions from within the PHPStan phar so it's broken with getVendorDir

mglaman avatar May 10 '24 16:05 mglaman

Well, that sucks. \DrupalFinder\DrupalFinderComposerRuntime::getVendorDir is picking up InstalledVersions from within the PHPStan phar so it's broken with getVendorDir

Lets try to harden this part. Another approach I have tried some time ago was an composer plugin which dumps the config.

https://github.com/webflo/drupal-finder-plugin/blob/1.x/src/DrupalFinderPlugin/Installer.php#L163

webflo avatar May 10 '24 19:05 webflo

@webflo thanks for looking into this, I paused and did a pivot at DrupalCon

mglaman avatar May 12 '24 23:05 mglaman

Any chance we can fix this soon? Would help at https://github.com/ddev/ddev-drupal-contrib/pull/53

weitzman avatar Jun 14 '24 12:06 weitzman

@weitzman Could you try https://github.com/webflo/drupal-finder/pull/73 thanks! This is my preferred approach. Thanks!

webflo avatar Jun 18 '24 22:06 webflo

Unfortunately I dont have time to test phpstan-drupal with the PR. And Drush no longer uses drupal-finder.

weitzman avatar Jun 19 '24 18:06 weitzman

I have created a new release for drupal-finder

webflo avatar Jun 28 '24 13:06 webflo

Thanks @webflo!

mglaman avatar Jun 28 '24 17:06 mglaman

Superseded by https://github.com/mglaman/phpstan-drupal/pull/790

webflo avatar Sep 24 '24 10:09 webflo