drupalorg-cli icon indicating copy to clipboard operation
drupalorg-cli copied to clipboard

Do not fail when using semver version

Open DuaelFr opened this issue 4 years ago • 4 comments

While trying to get release notes of a module installed by composer, we cannot know if it is using semver version numbers (new good practice) or if it has been converted for an old school drupal.org version number.

For example, I want to get the release notes for the CDN module in its 3.5.0 version given by composer outdated. The drupalorg prn cdn 3.5.0 command throw me a bunch of notices and no content because I should have used drupalorg prn cdn 8.x-3.5 instead.

In the near future, more modules will switch to the semver standard but in the mean time it could help if drupalorg-cli would translate the version for us.

DuaelFr avatar May 28 '20 09:05 DuaelFr

Ah yeah. The definitely has not been adjusted for semver, and that's going to be pretty hard, like it was for even implementing it for contrib. Just because it isn't standard and there's no flag on the API to say if a project or release is using it. But a quick regex should help us determine

mglaman avatar May 28 '20 11:05 mglaman

And the notices should be fixed too. Matt, will you fix (sooN) or should I give it a try and provide a PR?

hansfn avatar May 28 '20 11:05 hansfn

I don't have any free time until maybe this weekend, so it will be a few days before I could try

mglaman avatar May 28 '20 11:05 mglaman

@hansfn if you're working on these notices, you might also want to fix the ones you get when you use a module name that does not exist :)

I came with a quick and dirty fix for the semver issue if it can help you getting started: drupalorg_semver_support-81.patch.txt

Saldy I don't have much time to spend on this for now. Thanks a lot for your work on this amazing tool and for your reactivity!

DuaelFr avatar May 28 '20 12:05 DuaelFr