drupalorg-cli icon indicating copy to clipboard operation
drupalorg-cli copied to clipboard

Include commit links for maintainer:release-notes

Open colans opened this issue 5 years ago • 4 comments

It would be nice if commit links could be added to mrn just like Git Release Notes for Drush does.

colans avatar Apr 30 '19 21:04 colans

Which commit links are these? It links to the issue, which links to the commits, so at least there's a workaround.

greggles avatar May 01 '19 00:05 greggles

🤔This is a feature request for --commit-links, correct?

    // If the command was invoked with the --commit-links option
    if (!empty($commit_path)) {
      $item .= ' (<a href="' . $commit_path . $hash . '" title="View commit">#</a>)';
    }

It would append (HASH) after the issue. @colans is this the request?

Relevant code: https://git.drupalcode.org/project/grn/blob/7.x-2.x/grn.drush.inc#L298

mglaman avatar May 01 '19 01:05 mglaman

@mglaman Yes, exactly. It should be noted that these URLs changed recently now that the code is on GitLab. (Because of this, and earlier changes to d.o's infrastructure, this is actually broken in grn as well. See Commit links are incorrect for details.)

colans avatar May 01 '19 21:05 colans

Thanks for confirming and linking to the relevant issue! This shouldn't be too hard to implement.

mglaman avatar May 02 '19 00:05 mglaman