drupalorg-cli icon indicating copy to clipboard operation
drupalorg-cli copied to clipboard

Contributors are no longer listed in release notes

Open devbranch-vadym opened this issue 1 year ago • 3 comments

The maintainer:release-notes command no longer lists Contributors.

Steps to reproduce:

git clone --branch '1.4.x' https://git.drupalcode.org/project/single_content_sync.git
cd single_content_sync
drupalorg mrn 1.4.2 1.4.3 -f md

Resulting output:

/Add a summary here/

Contributors (0)

Changelog

Issues: 6 issues resolved.

Changes since 1.4.2:

Bug

  • #3366216: Added condition for hook_file_download and it will be working...
  • #3395514: Fix PHPUnit tests failures
  • #3395471: PHP 7.4 compatibility issue

Feature

Task

Expected output: There should be contributors listed.

devbranch-vadym avatar Oct 20 '23 13:10 devbranch-vadym

Yes, the same thing for me. Also, they disappeared from the list of issues too, previously there was something like this:

#3388157 by Murz, j.cowher: Handful of bug fixes

MurzNN avatar Jan 22 '24 06:01 MurzNN

I've debugged it a bit, seems this is because now the commit message is created by GitLab, and it misses the user names.

Here is the code to collect user names: https://github.com/mglaman/drupalorg-cli/blob/ea547b28ecbbfe8934195e5fb46b278c6c5c05e7/src/Cli/Command/Maintainer/ReleaseNotes.php#L299-L319

And it expects usernames listed in the commit message. So, no idea for now on how to fix this.

MurzNN avatar Jan 22 '24 07:01 MurzNN

The commit message is created from the MR title, so to restore this feature seems we should manually list all issue contributors in the MR title like this:

Issue #NNN by user1, user2, user3: Issue title

But seems there are no automation implemented for this, I raised a question in Slack about this: https://drupal.slack.com/archives/CGKLP028K/p1706086503684919

MurzNN avatar Jan 24 '24 09:01 MurzNN