Maximilian Girlich

Results 64 comments of Maximilian Girlich

I added an example to the second bullet point. I really meant looping over a list and slicing every element of a list under some (rare) condition. Though, now that...

I found a couple that are missing: * `copy_to()` * `db_*()`, e.g. `db_explain()` * `sql_*()` e.g. `sql_join()` * `rows_*()`

It feels quite unexpected to me that the database changes the column names. So, I'm not a big fan of the old behaviour. At least, this should be a warning....

Probably makes sense as this mistake happened even a couple of times in dplyr code. Do you want to create a PR?

Use `tbl_lazy` as most methods are written for this class.

Thanks for working on this. I'd be happy to see a PR for this 😄

Thanks for working on this directly. What do you think about a low level function `tib_assign_col(df, j, value)`? This should allow for some very good performance improvements. Though maybe this...

@hadley I think there are enough nice new features to make another release. Is there anything else you want to include? Maybe you want to have a look at the...

The release contains * much better error messages * a couple of small bugfixes and minor features * new translations for some backends * much nicer SQL While I really...

Thanks for the quick feedback. I'm fine with waiting for a review, already good to know that you consider it interesting. Some questions for the future: * Must all `children`...