Marius Gedminas

Things that seem worth bothering with: - [ ] suboptimal use of startswith() in [confparse.py](https://github.com/linkchecker/linkchecker/pull/432#discussion_r433635595), maybe reuse HTTP_SCHEMES - [ ] there's a missing `_()` wrapper in [confparse.py](https://github.com/linkchecker/linkchecker/pull/432/files/3c9e6266d7bef890e22eac10ee5a3f724f78b18e#diff-51589283e29e7948ca02748855a6d237), around the...

Sorry! We've forked wummel/linkchecker because of https://github.com/wummel/linkchecker/issues/699 and the original maintainer being missing in action, but we'e not familiar with the history of the codebase. I don't know what linkchecker-nagios...

I will do my best to review the PR, if it's not too large, to the best of my ability (I'm not familiar with the linkchecker codebase, but I have...

> I'll work out how to create and run some tests. I'm using this on a production box each night, so can keep an eye on it too. It would...

> It would be nice to have one integration test. I said one, because zero is bad (maybe all units work correctly but aren't hooked up together right), and more...

IIRC this piece of code is not dealing with files loaded from the filesystem. It's dealing with directory index HTML generated by linkchecker itself from os.listdir() data. That's Unicode (on...

+1 for removing a Makefile we don't know how to use. (I'd be tempted to replace it with a Makefile I do know how to use, but that's just me.)...

The long-term trend in the Python packaging ecosystem is to get rid of setup.py and executable metadata (hence PEP-517, PEP-518 etc.). Some commands have already been deprecated, e.g. setuptools's documentation...

I think we're in violent agreement here :)

I prefer linkchecker2. It's the Python convention (e.g. urllib -> urllib2 -> urllib3), and it explicitly acknowledges the project ancestry (yes, linkchecker2 is related to the older linkchecker). I don't...