--create and --update exit 1 when version control and sdist do not match

[wmedlar]

For example, with files tracked in VCS (git) and no manifest:

~/package $ check-manifest --create
lists of files in version control and sdist do not match!
missing from sdist:
  LICENSE.txt
  Makefile
  requirements.txt
  tests
  tests/test_a.py
  tests/test_b.py
no MANIFEST.in found
suggested MANIFEST.in rules:
  include *.txt
  include Makefile
  recursive-include tests *.py
creating MANIFEST.in
~/package $ echo $?
1

or when updating the manifest:

~/package $ check-manifest --update
lists of files in version control and sdist do not match!
missing from sdist:
  Makefile
suggested MANIFEST.in rules:
  include Makefile
updating MANIFEST.in
~/package $ echo $?
1

I would expect these flags to cause the program to exit 0, indicating a successful creation/update.

[mgedmin]

That makes sense, as long as check-manifest didn't encounter any files it doesn't know how to add.

I'm not likely to get around to this soon (new baby in the house), but feel free to ping me in a month or so. Or you could provide a pull request, if you've time.

[wmedlar]

Congratulations! 😄 I'm sure I'll be able to find the time to work on this.