check-manifest icon indicating copy to clipboard operation
check-manifest copied to clipboard

Do not depend on distutils

Open mgedmin opened this issue 4 years ago • 0 comments

In 21d396902acf61ffeeaa3d81d075a1f156dbaf42 I added a dependency on distutils.text_file.TextFile() because I thought that's what setuptools used to read MANIFEST.in files.

Later I realized that was wrong and that setuptools has its own code for this. I decided to stay with distutils because the stdlib moves slower, and I thought this would protect check-manifest users from breaking changes in setuptools.

However this comes at the cost of accuracy, and also people are talking about deprecating distutils: https://discuss.python.org/t/pep-632-deprecate-distutils-module/5134

mgedmin avatar Sep 08 '20 07:09 mgedmin