codelyzer icon indicating copy to clipboard operation
codelyzer copied to clipboard

No changelog for version 6.0.0

Open viceice opened this issue 4 years ago • 7 comments

The changelog entry for version 6.0.0 is missing.

viceice avatar Jul 06 '20 07:07 viceice

Also there is ?instead? a changelog for version 5.3.0 but no version 5.3 published to npm...

Dassderdie avatar Jul 06 '20 09:07 Dassderdie

The 5.3.0/6.0.0 changelog also mentions support for Angular 10, yet the project still has a hard dependency on @angular/core and @angular/compiler 9.0.0. Shouldn't those be devDependencies since v10 is supported in peerDependencies?

https://github.com/mgechev/codelyzer/blob/0b2e233457cbf3d326ac6138e5329138561b10ce/package.json#L96-L98

aramperes avatar Jul 09 '20 15:07 aramperes

@aramperes I noticed the same thing. It actually causes my custom linters not to work in combination with Angular 10 (throws some type errors).

Maybe it's worth it to file this as a separate issue?

jimivdw avatar Jul 10 '20 08:07 jimivdw

@jimivdw what kind of errors do you have? I have the latest version of Angular 10.0.3 and this on 6.0.0 and everything is fine on my project. Sounds not safe but still good to me to upgrade it.

C0ZEN avatar Jul 10 '20 14:07 C0ZEN

Also tslint which is deprecated should be replaced by a similar tool. This was also mentioned here: https://github.com/mgechev/codelyzer/issues/763 :) https://github.com/mgechev/codelyzer/blob/0b2e233457cbf3d326ac6138e5329138561b10ce/package.json#L94

mariusbolik avatar Jul 12 '20 08:07 mariusbolik

@C0ZEN seems I jumped to conclusions a bit too fast (updated my earlier comment accordingly). The type errors I got were actually related to a custom linter I have, where I import types from Angular (local, which is v10) which are different than the ones codelyzer uses (Angular v9).

A workaround for that would be to import the types from codelyzer/node_modules/@angular/compiler instead of just from @angular/compiler, but that's really not a proper solution.

jimivdw avatar Jul 13 '20 09:07 jimivdw

Hey everyone, sorry for the late response. I just saw this issue after digging into hundreds of @dependabot PRs.

We'll be moving to ESLint in the next few months and deprecating codelyzer. You'll be able to use angular-eslint, which currently has a similar feature set.

In v6 I added dependencies on Angular v9 so we can use the compiler API codelyzer understands. The pros of this approach is that as soon we don't drastically change the Angular template syntax codelyzer will work just fine with any Angular version.

The cons is that you'd now have Angular v10 and v9 in your project, which on its own will slow a little down the npm install step until we completely switch to ESLint.

mgechev avatar Aug 14 '20 22:08 mgechev