XmlSchemaClassGenerator
XmlSchemaClassGenerator copied to clipboard
[WIP] Log line numbers on schema validation errors
This is a pr for #387. It reports the line number of schema validations exceptions to the log in addition to the message.
I still need to collect some test cases and maybe tweak the formatting.
Codecov Report
Patch coverage: 11.53% and project coverage change: -0.69 :warning:
Comparison is base (
e4da0ad) 94.21% compared to head (cadf28c) 93.52%.
Additional details and impacted files
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 94.21% 93.52% -0.69%
==========================================
Files 21 21
Lines 2973 2998 +25
Branches 466 470 +4
==========================================
+ Hits 2801 2804 +3
- Misses 115 136 +21
- Partials 57 58 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| XmlSchemaClassGenerator/Generator.cs | 76.92% <11.53%> (-11.28%) |
:arrow_down: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for creating the PR. I'm willing to merge. Could you just add a simple test to keep the coverage?