gnome-shell-system-monitor-applet icon indicating copy to clipboard operation
gnome-shell-system-monitor-applet copied to clipboard

Published 20 hours ago • verified publisher icon mgalgs

Minutes to wait before resetting graph scale

Open czodroid opened this issue 9 months ago • 4 comments

Enhancement

For a system monitor, I'd like to see when things aren't going well. I made a patch to wait x minutes before resetting the graph scale. If you set 0 min, it's the same as before, it scales to the width of the graph, like 8 sec for me. That way I can see when the cpu, network and disks are not in a normal state...

What I tested

  • [x] Verified no regressions to existing functionality. (sure, 0 min like before)
  • [x] Tested on the following Gnome Shell versions: 47

czodroid avatar Mar 01 '25 16:03 czodroid

Shouldn't it always scale if the values are above the current max graph value? Seems like maybe this should only be avoiding graph downscaling, not upscaling... :thinking:

mgalgs avatar Mar 03 '25 03:03 mgalgs

Shouldn't it always scale if the values are above the current max graph value?

Yes! Also with my modification!

Seems like maybe this should only be avoiding graph downscaling, not upscaling... 🤔

That's my modification. Maybe you should change the comment from "Minutes to wait before resetting graph scale" to "Minutes to wait before scaling down the graph" (I'm French, sorry for my bad English)

czodroid avatar Mar 04 '25 17:03 czodroid

I think the idea makes sense. I probably won't have time to review this week but if anyone else gets a chance to review/test that would be helpful!

mgalgs avatar Mar 05 '25 00:03 mgalgs

@czodroid do you have "allow edits by maintainers" checked for this PR? I'm playing around with this a bit. I made a few style/naming/doc updates and also made it so that each new high water mark restarts the "cooldown" period (without clearing the cooldown max).

Can you take a look and make sure I've preserved all of your intended functionality? I've been running it for a bit here and I'm really liking how it affects my "net" graph especially.

Branch: graph-scale-reset-delay (Check the commits on that branch to find the latest revision)

mgalgs avatar Mar 12 '25 16:03 mgalgs

It's perfect!!!

And yes, the "net" graph is the reason I made this pull request! May be you can at the end of "prefs.js" set window.set_default_size(645, 765); 765 is height (with my fonts) to show the windows entirely.

Thanks and sorry for "allow edits by maintainers"

czodroid avatar Mar 14 '25 13:03 czodroid

Superseded-by: #117

mgalgs avatar Mar 19 '25 20:03 mgalgs