Marco Gaido

Results 42 comments of Marco Gaido

@jerryshao @vanzin I am pinging you because I am not sure about this PR. I mean, AFAIK Livy has no mechanism currently to create a "cluster" of Livy servers which...

the point here is: from the project perspective we should first achieve the same level of HA and robustness for the Livy server part. Then, we can also have it...

I agree they are different and they may also lead to separate solutions, but I'd prefer to work on a full proposal which covers both cases. You may want to...

> I think it may be better to cover those cases(if any) in method stop I don't really agree with you. Let me cc @vanzin for his opinion too on...

@jerryshao @vanzin you are more familiar than me on this. I see no issues, but I am not familiar with this part.

I am more familiar with the thriftserver part, so I am not confident reviewing this PR, btw the CI is failing, so a first step would be having the CI...

Then I would recommend fixing the tests on the master branch and then go ahead. It is the safest option IMHO.

this is not my main area of expertise, @vanzin and @jerryshao might be better reviewers

Hi @xutaima, I think you raised an important question, which I believe the fairseq community should start thinking seriously. There are many breaking changes that happen in fairseq and everyone...

This fix is causing many changes. The `submit` method is used for many purposes, such as adding jar, files, so I do not think is a good idea to have...