mfts
[đšī¸] Bug: Light dark mode and loader button in upgrade section
What side quest or challenge are you solving?
Bug
Points
W.r.t to Quest
Description
This issue address two bugs.
- Light dark mode
In billing page or upgrade modal the button background is not visible when hovered.
- Loader State
Regardless of which plan is chosen all options starts loading with the title Redirecting to stripe...
Expected Behaviour Button should be visible on hover and only selected plan should load.
Assigned to @JeevaRamanathan! Please open a draft PR linking this issue within 48h â ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đšī¸ Excited to have you ship this đ
![oss-gg[bot] avatar](https://avatars.githubusercontent.com/in/835270?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @mfts,
I have a question/request regarding the conflict in #982/#1144. Since another contributor worked on the same issue (as no issue was raised previously by them), I was unknowingly working on it as well. Upon noticing that, I discarded my commit in #982 to avoid conflicts and rebased to the main branch to pull in the latest changes and push only the required changes.
However, that PR automatically locked the conversation, which led me to create an unnecessary new PR for the same issue instead of adding a new commit to the original PR due to the lock.
Is there a specific reason for this lock, or should I have handled it differently?
Additionally requesting you close this issue from your end.
Assigned to @7uyash! Please open a draft PR linking this issue within 48h â ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đšī¸ Excited to have you ship this đ
@7uyash, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.
@7uyash has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.
Assigned to @Gururaj26! Please open a draft PR linking this issue within 48h â ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đšī¸ Excited to have you ship this đ
Assigned to @Gururaj26! Please open a draft PR linking this issue within 48h â ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đšī¸ Excited to have you ship this đ
@JeevaRamanathan Could you close this issue? As this is already addressed. I accidentally started working on this issue, later figured out that it was already resolved.
@Gururaj26. Oops! It seems there was a misunderstanding. However, if you had noticed the comments, I was asking a question to Marc in the same conversation after it was merged: https://github.com/mfts/papermark/issues/981#issuecomment-2423795458 and mentioned that he could close it afterward. But that's fine; I will close it. Thanks!
@Gururaj26, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.
@Gururaj26, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.
@Gururaj26 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.
@Gururaj26 has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.