papermark icon indicating copy to clipboard operation
papermark copied to clipboard

opt-in-to-group-permission

Open AshishViradiya153 opened this issue 1 year ago • 7 comments

fixes #697

  • The user can go to a specific group from the document page to set permissions.
  • There were 3 or 4 cases where the folder tree view was not updated, and this has also been fixed.

image image

It will redirect to group permission page

AshishViradiya153 avatar Oct 14 '24 11:10 AshishViradiya153

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 14 '24 11:10 vercel[bot]

PR Summary

  • Enhancement to Dataroom Document Card

    • This update introduces a system to manage group permission dialog, along with adding a new permissions setting feature in the dropdown menu. This feature initiates the newly developed GroupNavigation component when the permission dialog is open.
  • Introduction of the Group Navigation Component

    • A brand new component that offers a dialog for setting group permissions. It lists various viewer groups and while fetching data, a loading spinner enhances the user experience.
  • Refinement in Dataroom Sortable List and Upload Zone Component

    • Both of these components now include a feature that automatically refreshes the folder data after certain actions. It makes keeping track of updates more efficient.
  • Amendments in Add Document Modal and Folder Card Component

    • On adding a document, the folder data gets refreshed. Similarly, the Folder Card Component now has a state to manage group permission dialog and a permissions setting feature in the dropdown menu.
  • Improvements in Move Dataroom Documents Function and Dataroom SWR Hook

    • The function to move documents now also carries out a folder data refresh post every move. Additionally, the Dataroom SWR Hook has been enhanced to update folder data when certain conditions are fulfilled.

what-the-diff[bot] avatar Oct 14 '24 11:10 what-the-diff[bot]

@mfts One more thing, I can only see the folder tree on the home not documents. Should I create an issue for that?

https://github.com/user-attachments/assets/2d223ba2-205f-4c35-8e28-d6c9f20eca52) i have documen also but we don't show that if we on home!!!

AshishViradiya153 avatar Oct 14 '24 11:10 AshishViradiya153

One more thing, I can only see the folder tree on the home not documents. Should I create an issue for that?

https://github.com/user-attachments/assets/2d223ba2-205f-4c35-8e28-d6c9f20eca52) i have documen also but we don't show that if we on home!!!

Good catch! That's something we haven't quite solved yet.

Generally, in the dataroom view tree there is no "home" folder. However that would make sense to add as a "fictional" parent folder.

Would be awesome to add that in a separate PR perhaps

mfts avatar Oct 15 '24 03:10 mfts

THANKS @mfts. what about this PR?

AshishViradiya153 avatar Oct 15 '24 08:10 AshishViradiya153

@AshishViradiya153 while this is a good idea. I think in the current form it's not really useful.

What would be useful, is to set the permission for the folder/document for a certain group from that dialog popup.

What do you think?

mfts avatar Oct 19 '24 09:10 mfts

@mfts I got it, you're right! and also makes sense!

AshishViradiya153 avatar Oct 19 '24 10:10 AshishViradiya153

@AshishViradiya153 do you want to continue working on this group permissions pop-up or rather open a new PR?

mfts avatar Oct 22 '24 06:10 mfts

@mfts I will open a new PR for that and a new issue as well. I think it will be a big PR. I have already started and finished 40% of the work, but it will take more time than I initially thought, Sorry.

AshishViradiya153 avatar Oct 24 '24 03:10 AshishViradiya153

@AshishViradiya153 no problem. Open the PR before Oct 31 so i can still reward you even if it takes longer to merge

mfts avatar Oct 24 '24 03:10 mfts