fix: Keep state in dataroom view between document and dataroom view #783

[Nithin-532]

Bug: The folderId state is getting resetted everytime when we changing the view.

Fix: I lifted the state of folderId in DataroomViewer component to DataroomView component.

Screencast from 13-10-24 11_40_10 PM IST.webm

[vercel[bot]]

@Nithin-532 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[what-the-diff[bot]]

PR Summary

• Enhanced DataroomViewer Component We've upgraded our DataroomViewer component's functionality, allowing it to accept additional information (folderId and setFolderId) directly from its surrounding environment.

• Simplified State Management We removed the local state initiation for folderId and setFolderId. These pieces of data are now received as parameters, enhancing flexibility and control over component behavior.

• Improved DataroomView Component We introduced local state management for folderId and setFolderId within the DataroomView component, providing it with the ability to manage these data in its scope.

• Enhanced Data Flow to Child Components We've improved how we distribute information to component's offspring. The folderId and setFolderId are now transferred to the relevant child components within the DataroomView, improving hierarchy operation and data accessibility.

[Nithin-532]

I have read the CLA Document and I hereby sign the CLA

[Nithin-532]

recheck

[mfts]

@Nithin-532 great job! it's such a simple change.

One small request and probably that might take some fiddling around but even tho the folder state is preserved, for some reason the folder tree doesn't expand to the current folder automatically

Could you test this with a deeply-nested file (i.e. 2 or more folders deep) and see if you can fix the issue :)

https://github.com/user-attachments/assets/4ca4f448-486e-46e3-864e-e8888d76b51a

[Nithin-532]

@mfts sure

[Nithin-532]

@mfts I somewhat solved the problem. Here is the video.

Screencast from 14-10-24 05:57:38 PM IST.webm

But I think this is not an optimal approach. I nested through all the folders and children of those folders to find the path of the folderId that has been selected.

[mfts]

But I think this is not an optimal approach. I nested through all the folders and children of those folders to find the path of the folderId that has been selected.

@Nithin-532 I see. let me know if you want me to review some part of the code