papermark icon indicating copy to clipboard operation
papermark copied to clipboard

[🕹️] Bug Hunter : Email Input Black Background After Choosing Dark Mode.

Open aritradevelops opened this issue 1 year ago • 9 comments

What side quest or challenge are you solving?

Bug Hunter

Points

50 - 150

Description

Bug Description

The input email which was originally having white background, after sigining in and choosing dark mode and then signing out. The input button color has changed to black although the page have no theme switching context.

Steps to reproduce

  1. Sign In
  2. Choose Dark Theme
  3. Sign out

Provide proof that you've completed the task

image

aritradevelops avatar Oct 13 '24 07:10 aritradevelops

/assign

aritradevelops avatar Oct 13 '24 07:10 aritradevelops

Assigned to @aritradevelops! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 13 '24 07:10 oss-gg[bot]

/assign

SaqibOO7 avatar Oct 13 '24 10:10 SaqibOO7

Assigned to @SaqibOO7! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 13 '24 10:10 oss-gg[bot]

/assign

bksingh5052 avatar Oct 13 '24 11:10 bksingh5052

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 13 '24 11:10 oss-gg[bot]

@mfts See I can fix this thing with one extra css class, but what do you want there eventually is my real concern, do you want to keep the theming over here, then I guess adding a theme switching button and implementing proper theming of every component will help. Or if you want to just keep this page in light theme then my fix will work. Let me know what do you want! And I will request you to assign this to me, Thanks!

After My Fix : image image

aritradevelops avatar Oct 13 '24 12:10 aritradevelops

@aritradevelops great find and good solution. yes this should always be a white background therefore overriding the dark: className makes sense.

/award 100

mfts avatar Oct 14 '24 02:10 mfts

Awarding aritradevelops: 100 points 🕹️ Well done! Check out your new contribution on oss.gg/aritradevelops

oss-gg[bot] avatar Oct 14 '24 02:10 oss-gg[bot]