last used indicator on login page fixed

[sahiladit]

Fixes:#841

#what does this pr do: Now the indicator now only pops up when user click on any of the login mode and not when the user enters for the first time.

[vercel[bot]]

@sahiladit is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[mfts]

@sahiladit could you please share a video what you mean? if the user hasn't logged in ever then of course there's no "last used".

[sahiladit]

@sahiladit could you please share a video what you mean? if the user hasn't logged in ever then of course there's no "last used".

It fixes #841

[mfts]

ok sounds good. please sign the CLA

[sahiladit]

ok sounds good. please sign the CLA

Can you give me the steps to sign it? It's my first time contributing to an org..

[mfts]

@sahiladit

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

[sahiladit]

recheck

[sahiladit]

I have read the CLA Document and I hereby sign the CLA

[sahiladit]

recheck

[JeevaRamanathan]

Hi @sahiladit, It's great to hear on your first contribution, many more to go! One small thing...I tried with incorporating your changes but I seems like the similar behavior still on. The expected behaviour is until it get's navigated to the next screen / till successful login the indicator shouldn't show. And say lastlogin is indicating on Google and if the user click LinkedIn it should set to linkedin only when the user comes back again to login screen. Otherwise maybe you can try sharing a video if it works accordingly like mentioned. Expected:

https://github.com/user-attachments/assets/91c91ca2-414b-4df8-b83a-77b8ca305915

https://lex.page/auth https://app.formbricks.com/auth/login

And a sample implementations can be find here https://github.com/formbricks/formbricks/pull/3376

[sahiladit]

Hi @sahiladit, It's great to hear on your first contribution, many more to go! One small thing...I tried with incorporating your but I seems like the similar behavior still on. The expected behaviour is until it get's navigated to the next screen / till successful login the indicator shouldn't show. And say lastlogin is indicating on Google and if the user click LinkedIn it should set to linkedin only when the user comes back again to login screen. Otherwise maybe you can try sharing a video if it works accordingly like mentioned. Expected:

13.10.2024_12.02.42_REC.mp4 https://lex.page/auth https://app.formbricks.com/auth/login

And a sample implementations can be find here formbricks/formbricks#3376

I think i have resolved this ,try to run my code ,it's not merged yet,and if you still find it let me know.

[JeevaRamanathan]

I tried with incorporating your *changes

Hi @sahiladit, I’m aware the code hasn’t been merged yet. Before posting my previous comment, I incorporated your changes into the code (tried with your code), but the issue still remains. Would you mind checking it :-)

[sahiladit]

I tried with incorporating your *changes

Hi @sahiladit, I’m aware the code hasn’t been merged yet. Before posting my previous comment, I incorporated your changes into the code (tried with your code), but the issue still remains. Would you mind checking it :-)

Okay,thanks for the check, i'll try to resolve it.

[mfts]

@sahiladit any update on the last changes?

[sahiladit]

@sahiladit any update on the last changes?

Making some changes, will open a pr today.

[mfts]

@sahiladit just add to this PR :)

[sahiladit]

how can i change the code in existing pr?

[JeevaRamanathan]

You can make changes in the same branch in your code(sahiladit:fix/last-used-indicator) and push it.

[sahiladit]

i have made the changes,should i recheck it here?

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
papermark	❌ Failed (Inspect)			Oct 19, 2024 9:32am

[mfts]

@sahiladit please have a look at the last build error.

[mfts]

Thanks for your effort. I didn't hear back from you, so I implemented it myself here https://github.com/mfts/papermark/pull/1296

Awarding you for the effort nonetheless /award 25

[oss-gg[bot]]

Awarding sahiladit: 25 points 🕹️ Well done! Check out your new contribution on oss.gg/sahiladit