papermark icon indicating copy to clipboard operation
papermark copied to clipboard

Improve Loading Performance and UI in dark mode

Open ShreyasLakhani opened this issue 1 year ago • 6 comments

  • Fix the loading problem, when user purchase subscription.

  • change the text color in dark mode.

  • remove unwated CSS

  • Before

https://github.com/user-attachments/assets/54414609-aef7-400a-a098-6026b2f0e28e

https://github.com/user-attachments/assets/ca561edf-4f75-4b9e-b5ba-5e0d5570e718

  • After

https://github.com/user-attachments/assets/4add00c6-1d9d-4c07-be8c-b002976a2c65

https://github.com/user-attachments/assets/bc0df25b-cefe-47ba-8596-0815c08a5bc1

ShreyasLakhani avatar Oct 12 '24 13:10 ShreyasLakhani

@ShreyasLakhani is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 12 '24 13:10 vercel[bot]

please ingore pages/404.tsx file. This issue is already resolved.

ShreyasLakhani avatar Oct 12 '24 13:10 ShreyasLakhani

@mfts can you review my PR and give me feedback.

ShreyasLakhani avatar Oct 13 '24 02:10 ShreyasLakhani

@ShreyasLakhani please merge the current main branch and resolve conflicts. no need to change the 404 page. it's already in dark mode adjusted.

For the buttons on the upgrade modal, they should not be clickable if the user clicked one button. so disable the one that's not clicked

mfts avatar Oct 13 '24 05:10 mfts

@ShreyasLakhani overall good start.

please merge in the current main branch and resolve existing conflicts.

other notes:

  • please keep the useState variables consistent between the two components (clickedPlan and clickedPlanState)
  • add a disabled attribute to the buttons that checks if the clickedPlan != null so that it disables other buttons from being clicked.

mfts avatar Oct 16 '24 11:10 mfts

@mfts Done.

resolve all conflicts and merge in main branch.

Let me know if there still error.

ShreyasLakhani avatar Oct 16 '24 16:10 ShreyasLakhani

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
papermark ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:22am

vercel[bot] avatar Oct 19 '24 09:10 vercel[bot]

Awarding ShreyasLakhani: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/ShreyasLakhani

oss-gg[bot] avatar Oct 19 '24 09:10 oss-gg[bot]