papermark icon indicating copy to clipboard operation
papermark copied to clipboard

Improve document πŸ“„ "Action" tab

Open AshishViradiya153 opened this issue 1 year ago β€’ 6 comments

Fixes https://github.com/mfts/papermark/issues/677

  • The user can create a data room using the "Action" tabs if they have the correct subscription; otherwise, an "Upgrade Plan" tab will be shown.
  • Display a tooltip for "Upload a new version." (The problem is that if we wrap the button with a tooltip, the button event doesn't work.)

image image

AshishViradiya153 avatar Oct 07 '24 17:10 AshishViradiya153

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Oct 07 '24 17:10 vercel[bot]

@mfts could you please review and let me know if there’s anything further needed from my side?

AshishViradiya153 avatar Oct 08 '24 15:10 AshishViradiya153

@AshishViradiya153 I think we should hide the "add to dataroom" if the user is either on free or pro and not on trial

mfts avatar Oct 09 '24 02:10 mfts

@mfts "Add to Dataroom" is always there, which I think is great. If the user doesn't have a Dataroom, it will be hidden. Additionally, users can create a new Dataroom using the "Create Dataroom" option if they have the right plan; otherwise, an upgrade popup will appear.

image here its shows create dataroom and add to dataroom, if dont have a subscription than it wil show upgrad plan tab.

/documents image

AshishViradiya153 avatar Oct 09 '24 03:10 AshishViradiya153

@mfts Recheck please

AshishViradiya153 avatar Oct 11 '24 03:10 AshishViradiya153

@AshishViradiya153 thanks. I still think it's confusing to have a "Create New Dataroom" on a document dropdown. It's out of context for most users.

  • Let's remove the "Create New Dataroom" option from the dropdowns altogether.
  • Hide the "Add to dataroom" when user doesn't have a dataroom

mfts avatar Oct 11 '24 13:10 mfts

@mfts Please recheck, I have removed the "Create New Dataroom" option and also hidden "datarooms" if there aren't any.

Thank you.

AshishViradiya153 avatar Oct 12 '24 17:10 AshishViradiya153

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
papermark βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 13, 2024 5:13am

vercel[bot] avatar Oct 13 '24 05:10 vercel[bot]

/award 150

mfts avatar Oct 13 '24 05:10 mfts

@AshishViradiya153 i think something went wrong with the award. could you please open an issue referencing this PR and then I award you there

mfts avatar Oct 13 '24 05:10 mfts